Skip to content

chore: replace symlinks with copies for README.rst#16653

Merged
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:replace-readme-symlinks
Apr 15, 2026
Merged

chore: replace symlinks with copies for README.rst#16653
jskeet merged 1 commit intogoogleapis:mainfrom
jskeet:replace-readme-symlinks

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented Apr 15, 2026

No description provided.

@jskeet jskeet requested a review from parthea April 15, 2026 11:56
@jskeet jskeet requested review from a team as code owners April 15, 2026 11:56
@jskeet jskeet requested review from TrevorBergeron and removed request for a team April 15, 2026 11:56
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces symlinked README files with package-specific README.rst documentation across several Google Cloud Python libraries, including bigquery-magics, db-dtypes, and various google-cloud packages. The new documentation provides installation instructions, supported Python versions (>= 3.9), and usage examples. Feedback was provided to correct a SQL syntax error in the BigQuery magics example, fix a method name typo and grammatical error in the Document AI Toolbox documentation, and resolve a formatting typo in the Runtime Configurator documentation.

I am having trouble creating individual review comments. Click here to see my feedback.

packages/bigquery-magics/docs/README.rst (100)

medium

In BigQuery SQL, table identifiers containing hyphens must be enclosed in backticks, not single quotes. Using single quotes will result in a syntax error as it is interpreted as a string literal.

    FROM bigquery-public-data.usa_names.usa_1910_current

packages/google-cloud-documentai-toolbox/docs/README.rst (24)

medium

There is a typo in the method name and a grammatical error. The method should be BatchProcessDocuments() (plural) to match the reference in line 6, and buckets should be followed by contain.

But you must enable the Storage API to access GCS buckets that contain the output of BatchProcessDocuments(). 

packages/google-cloud-runtimeconfig/docs/README.rst (185)

medium

Typo: code-based should be code-based without the extra space.

      if the code-based configuration gets applied first.

@jskeet jskeet merged commit d0581cc into googleapis:main Apr 15, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants