chore: redirect git clones to use local files in CI conditional tests#16652
Merged
jskeet merged 1 commit intogoogleapis:mainfrom Apr 15, 2026
Merged
chore: redirect git clones to use local files in CI conditional tests#16652jskeet merged 1 commit intogoogleapis:mainfrom
jskeet merged 1 commit intogoogleapis:mainfrom
Conversation
Redirects git clones for core dependencies to the local repository for both performance (avoiding unnecessary cloning) and correctness (testing HEAD of everything).
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CI script to redirect git clones for core dependencies to the local repository, improving performance and ensuring local changes are tested. The review identifies critical issues regarding git configuration overwriting and global state leakage on CI runners, recommending the use of the --add flag and a cleanup trap.
Comment on lines
+44
to
+45
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | ||
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" |
Contributor
There was a problem hiding this comment.
There are two significant issues with this implementation:
- Configuration Overwrite: By default,
git configreplaces the existing value for a key. Line 45 will overwrite the setting from line 44, meaning only URLs ending in.gitwill be redirected. To support both URL variants, you must use the--addflag for the second command. - Global State Leakage: Using
--globalmodifies the git configuration for the user profile on the CI runner. In environments where runners are reused (e.g., self-hosted runners), this configuration will persist and may interfere with subsequent jobs that expect to clone from the real GitHub repository.
It is recommended to use a trap to ensure the configuration is unset when the script exits, and to use --add for the second configuration entry.
Suggested change
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | |
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" | |
| git config --global url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python" | |
| git config --global --add url."${PROJECT_ROOT}".insteadOf "https://github.com/googleapis/google-cloud-python.git" | |
| trap 'git config --global --unset-all url."${PROJECT_ROOT}".insteadOf' EXIT |
parthea
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redirects git clones for core dependencies to the local repository for both performance (avoiding unnecessary cloning) and correctness (testing HEAD of everything).