Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .librarian/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ libraries:
# Allow release for google-crc32c once this bug is fixed.
- id: "google-crc32c"
release_blocked: true
# TODO(https://github.com/googleapis/google-cloud-python/issues/16600):
# Allow release for google-cloud-spanner after tests are fixed.
Comment on lines +40 to +41
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For clarity, it's better to describe the current action (blocking the release) rather than the future action (allowing the release). This makes it easier to understand the purpose of this configuration at a glance. Also, the TODO(URL) format is unconventional. A more standard comment format would improve readability.

# Block release for google-cloud-spanner due to failing CI tests.
# See: https://github.com/googleapis/google-cloud-python/issues/16600

- id: "google-cloud-spanner"
release_blocked: true
Loading