Skip to content

TimestampRange should allow customization of inclusive/exclusive #2608

Closed
Closed
TimestampRange should allow customization of inclusive/exclusive#2608
Assignees
lukesneeringer
Labels
api: bigtableIssues related to the Bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Description

@destijl
destijl
opened on Oct 25, 2016

Currently TimestampRange supports only inclusive lower, exclusive upper:
https://googlecloudplatform.github.io/google-cloud-python/stable/bigtable-row-filters.html#google.cloud.bigtable.row_filters.TimestampRange

My application expects inclusive upper timestamp bounds. The super hacky workaround I currently have to make it work with bigtable is adding 1ms (minimum timestamp resolution) onto all end timestamps.

It would be great if I could control this behavior, just as for the value range filter:
https://googlecloudplatform.github.io/google-cloud-python/stable/bigtable-row-filters.html#google.cloud.bigtable.row_filters.ValueRangeFilter

Activity

  1. dhermes commented on Oct 25, 2016

    @dhermes
    dhermes
    on Oct 25, 2016
    Contributor

    We are at the mercy of the spec

    // Specified a contiguous range of microsecond timestamps.
message TimestampRange {
  // Inclusive lower bound. If left empty, interpreted as 0.
  int64 start_timestamp_micros = 1;

  // Exclusive upper bound. If left empty, interpreted as infinity.
  int64 end_timestamp_micros = 2;
}

    For now, your workaround is what I would recommend, but we can certainly consider adding this feature.

  2. dhermes
    added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: bigtableIssues related to the Bigtable API.
    on Oct 25, 2016
  3. dhermes
    self-assigned this
    on Oct 25, 2016
  4. lukesneeringer
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Apr 19, 2017
  5. lukesneeringer
    closed this as completedon Aug 11, 2017
  6. theacodes
    unassigned
    dhermes
    on Sep 28, 2018
  7. JustinBeckwith
    assigned
    lukesneeringer
    on Feb 1, 2021
  8. parthea
    added a commit that references this issue on Oct 21, 2023

    automl: add base dataset samples for automl ga [(#2608)](GoogleCloudP…

    0e0d6a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: bigtableIssues related to the Bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions