Skip to content

Can we enable "Require pull request reviews before merging" #2317

Closed

Description

@dhermes

GitHub recently added the ability to "approve" a PR (instead of typing LGTM). From the branch settings UI:

screen_shot_001

Can we check the box? Though not sure how this works in two situations

  • An owner "approves" their own PR when that is "bad"
  • An owner needs to "approve" their own PR when they need to do an emergency merge

Activity

  1. added
    type: questionRequest for information or clarification. Not an issue.
    on Sep 15, 2016
  2. dhermes commented on Sep 15, 2016

    @dhermes
    ContributorAuthor

    This answers the bullet about emergency merges:

    screen_shot_002

  3. lukesneeringer commented on Apr 19, 2017

    @lukesneeringer
    Contributor

    I intend to turn this on very soon. (It is part of a larger initiative I am working on, and I do not need the issue to track it. :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

type: questionRequest for information or clarification. Not an issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions