Repository navigation
Introduce options to serialize closures for batch processing - #886
Merged
Merged
Conversation
dwsupplee
requested review from
chingor13,
jdpedrie and
tmatsuo
as code owners
February 6, 2018 18:51
tmatsuo
approved these changes
Feb 6, 2018
chingor13
approved these changes
Feb 6, 2018
chingor13
left a comment
Contributor
There was a problem hiding this comment.
Other than the naming of one function, LGTM.
| * @param array $options | ||
| * @return array | ||
| */ | ||
| private function setWrappedClientConfig(array $options) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jdpedrie
approved these changes
Feb 6, 2018
| namespace Google\Cloud\Core\Batch; | ||
|
|
||
| /** | ||
| * A closure serializer implementation utilzing |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
Author
|
Thanks for the feedback guys, updated. PTAL. |
dwsupplee
force-pushed
the
closure-serialization
branch
2 times, most recently
from
February 6, 2018 20:35
6b51470 to
cea04fb
Compare
chingor13
approved these changes
Feb 6, 2018
jdpedrie
approved these changes
Feb 6, 2018
Merged
gcf-owl-bot Bot
added a commit
that referenced
this pull request
Feb 29, 2024
Source-Link: googleapis/googleapis@0df0f51 Source-Link: googleapis/googleapis-gen@b0b8f14 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYjBiOGYxNDdhNzcxNjJiYmM2MDNjYzFlMDQ3NTJhMzYyMWUxMmViNSJ9
saranshdhingra
pushed a commit
that referenced
this pull request
Mar 6, 2024
* feat: Update Compute Engine API to revision 20240220 (#886) Source-Link: googleapis/googleapis@0df0f51 Source-Link: googleapis/googleapis-gen@b0b8f14 Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiYjBiOGYxNDdhNzcxNjJiYmM2MDNjYzFlMDQ3NTJhMzYyMWUxMmViNSJ9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #588
@chingor13 What do you think? The goal of this approach was to add a lower friction way for users to supply closures to configurations used in the batch daemon. I looked at making these changes in
Google\Cloud\Core\Batch\SysvConfigStoragebut was concerned it wasn't very straight forward to supply a custom interface when initializing the daemon.