Skip to content

fix: Remove unset content type in system test#2071

Merged
dwsupplee merged 1 commit into
googleapis:masterfrom
jdpedrie:storage-system-test-remove-unset-contenttype
Jun 27, 2019
Merged

fix: Remove unset content type in system test#2071
dwsupplee merged 1 commit into
googleapis:masterfrom
jdpedrie:storage-system-test-remove-unset-contenttype

Conversation

@jdpedrie

Copy link
Copy Markdown
Contributor

This operation is not necessary and may be responsible for kokoro test failures.

@jdpedrie jdpedrie added the api: storage Issues related to the Cloud Storage API. label Jun 27, 2019
@jdpedrie jdpedrie requested a review from dwsupplee as a code owner June 27, 2019 17:34
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2019

@dwsupplee dwsupplee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the driver for this call originally?

@dwsupplee

Copy link
Copy Markdown
Contributor

@jdpedrie and I chatted offline about this, looks to be a relic that is no longer necessary.

@codecov

codecov Bot commented Jun 27, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@32ba359). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2071   +/-   ##
=========================================
  Coverage          ?   92.57%           
  Complexity        ?     4379           
=========================================
  Files             ?      304           
  Lines             ?    13014           
  Branches          ?        0           
=========================================
  Hits              ?    12048           
  Misses            ?      966           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32ba359...414691b. Read the comment docs.

@dwsupplee dwsupplee merged commit 259dbe9 into googleapis:master Jun 27, 2019
@jdpedrie jdpedrie mentioned this pull request Jun 27, 2019
@jdpedrie jdpedrie deleted the storage-system-test-remove-unset-contenttype branch June 27, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants