Skip to content

docs: Update samples.#1998

Merged
dwsupplee merged 2 commits into
masterfrom
autosynth-container
Jun 24, 2019
Merged

docs: Update samples.#1998
dwsupplee merged 2 commits into
masterfrom
autosynth-container

Conversation

@yoshi-automation

@yoshi-automation yoshi-automation commented Jun 4, 2019

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Container/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:846102ebf7ea2239162deea69f64940443b4147f7c2e68d64b332416f74211ba
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/container/artman_container_v1.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-container-v1.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/ClusterManagerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/ClusterManagerClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/ClusterManagerSmokeTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/ClusterManagerClientTest.php.
synthtool > Cleaned up 1 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: container Issues related to the Kubernetes Engine API API. label Jun 4, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 4, 2019
@codecov

codecov Bot commented Jun 4, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@d5fa88e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1998   +/-   ##
=========================================
  Coverage          ?   92.57%           
  Complexity        ?     4378           
=========================================
  Files             ?      304           
  Lines             ?    13012           
  Branches          ?        0           
=========================================
  Hits              ?    12046           
  Misses            ?      966           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5fa88e...67f5c35. Read the comment docs.

@jdpedrie jdpedrie added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 11, 2019
@jdpedrie jdpedrie added needs work This is a pull request that needs a little love. and removed 🚨 This issue needs some love. labels Jun 12, 2019
@googlebot

googlebot commented Jun 24, 2019

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jun 24, 2019
@jdpedrie jdpedrie changed the title [CHANGE ME] Re-generated Container to pick up changes in the API or client library generator. Update samples. Jun 24, 2019
@jdpedrie jdpedrie removed the needs work This is a pull request that needs a little love. label Jun 24, 2019
@jdpedrie jdpedrie requested a review from dwsupplee June 24, 2019 17:00
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 24, 2019
@jdpedrie jdpedrie changed the title Update samples. docs: Update samples. Jun 24, 2019
@dwsupplee dwsupplee added cla: yes This human has signed the Contributor License Agreement. and removed 🚨 This issue needs some love. cla: no This human has *not* signed the Contributor License Agreement. labels Jun 24, 2019
@googlebot

googlebot commented Jun 24, 2019

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@dwsupplee dwsupplee merged commit 0dc05cb into master Jun 24, 2019
@jdpedrie jdpedrie mentioned this pull request Jun 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jdpedrie jdpedrie jdpedrie approved these changes

@dwsupplee dwsupplee dwsupplee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: container Issues related to the Kubernetes Engine API API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshi-automation @googlebot @jdpedrie @dwsupplee @kokoro-team