feat(firestore-api): add explicit ./protos/protos package subpath export - #9105
Conversation
…a files - Add ./protos/protos subpath export mapping directly to compiled protos declarations and implementations - Add ./protos/* subpath wildcard export to expose raw proto schemas and JSON definitions - Retain backward-compatible ./build/protos/* aliases
There was a problem hiding this comment.
Code Review
This pull request adds subpath exports for ./protos/protos, ./protos/*, and ./build/protos/* to the package.json of @google-cloud/firestore-api. However, because this package is an auto-generated client library, manually editing its configuration will result in these changes being overwritten during the next regeneration cycle. It is recommended to apply these changes upstream in the generator or templates.
| "./protos/protos": { | ||
| "types": "./build/protos/protos.d.ts", | ||
| "default": "./build/protos/protos.js" | ||
| }, |
There was a problem hiding this comment.
This package (@google-cloud/firestore-api) is an auto-generated client library. Manually editing its package.json to add these subpath exports will result in them being overwritten during the next regeneration cycle. Please apply these changes upstream in the generator or templates instead.
References
- Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.
There was a problem hiding this comment.
We've added package.json to librarian.yaml keep list, so this file shouldn't be overwritten.
- Add explicit ./protos/protos subpath export mapping directly to compiled protos declarations and implementations - Keep strictly explicit subpath definitions without wildcards
Description
Adds explicit
./protos/protossubpath export to@google-cloud/firestore-apito support clean proto imports withoutbuild/directory exposure:./build/protos/protosand./protosentries for compatibility.Verification
npm pack --dry-run: successfully validated package export targets.