firestore: only pay .stack cost in error paths - #9102
Open
rockwotj wants to merge 1 commit into
Open
Conversation
`.stack` is relatively expensive to compute and currently every RPC in Firestore captures the stack, although it's only used in the error cases. We can improve the performance in V8 by deferring source map resolution to only error cases.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors how callsite error stacks are captured across several Firestore files by storing the Error object itself (as callsiteError) and deferring the .stack access. However, a critical compilation error was introduced in bulk-writer.ts where a reference to the old stack variable was missed in a catch block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.stackis relatively expensive to compute and currently every RPC inFirestore captures the stack, although it's only used in the error cases.
We can improve the performance in V8 by deferring source map resolution
to only error cases.