Node 22 upgrade all dependencies - #9095
Conversation
This reverts commit 0a750b2.
…/googleapis/google-cloud-node into node-22-upgrade-all-dependencies # Conflicts: # handwritten/bigquery/package.json
…iles" This reverts commit 8c9830e.
…/googleapis/google-cloud-node into node-22-upgrade-all-dependencies
There was a problem hiding this comment.
Code Review
This pull request updates various dependencies and Node.js engine requirements across multiple packages and test fixtures. The reviewer identified a critical issue where several test fixtures were incorrectly updated to use registry versions of dependencies instead of the required local tarball references, which would prevent local changes from being properly tested.
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@google-cloud/common": "file:./google-cloud-common.tgz" | ||
| "@google-cloud/common": "^8.0.0" |
There was a problem hiding this comment.
The dependency on @google-cloud/common in this kitchen test fixture was incorrectly changed from a local tarball reference (file:./google-cloud-common.tgz) to a registry version (^8.0.0). Kitchen/system tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "@google-cloud/common": "^8.0.0" | |
| "@google-cloud/common": "file:./google-cloud-common.tgz" |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "gcp-metadata": "file:./gcp-metadata.tgz" | ||
| "gcp-metadata": "^9.0.0" |
There was a problem hiding this comment.
The dependency on gcp-metadata in this kitchen test fixture was incorrectly changed from a local tarball reference (file:./gcp-metadata.tgz) to a registry version (^9.0.0). Kitchen/system tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "gcp-metadata": "^9.0.0" | |
| "gcp-metadata": "file:./gcp-metadata.tgz" |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "google-auth-library": "file:./google-auth-library.tgz" | ||
| "google-auth-library": "^11.0.0" |
There was a problem hiding this comment.
The dependency on google-auth-library in this kitchen test fixture was incorrectly changed from a local tarball reference (file:./google-auth-library.tgz) to a registry version (^11.0.0). Kitchen/system tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "google-auth-library": "^11.0.0" | |
| "google-auth-library": "file:./google-auth-library.tgz" |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "googleapis-common": "file:./googleapis-common.tgz" | ||
| "googleapis-common": "^9.0.0" |
There was a problem hiding this comment.
The dependency on googleapis-common in this kitchen test fixture was incorrectly changed from a local tarball reference (file:./googleapis-common.tgz) to a registry version (^9.0.0). Kitchen/system tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "googleapis-common": "^9.0.0" | |
| "googleapis-common": "file:./googleapis-common.tgz" |
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "@google-cloud/pubsub": "file:./pubsub.tgz" | ||
| "@google-cloud/pubsub": "^6.0.0" |
There was a problem hiding this comment.
The dependency on @google-cloud/pubsub in this sample test fixture was incorrectly changed from a local tarball reference (file:./pubsub.tgz) to a registry version (^6.0.0). These tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "@google-cloud/pubsub": "^6.0.0" | |
| "@google-cloud/pubsub": "file:./pubsub.tgz" |
| "devDependencies": { | ||
| "@types/node": "^22.15.2", | ||
| "gapic-tools": "./gapic-tools.tgz", | ||
| "gapic-tools": "^2.0.0", |
There was a problem hiding this comment.
The devDependency on gapic-tools in this showcase echo client test package was incorrectly changed from a local tarball reference (./gapic-tools.tgz) to a registry version (^2.0.0). These tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "gapic-tools": "^2.0.0", | |
| "gapic-tools": "./gapic-tools.tgz", |
| "dependencies": { | ||
| "@grpc/grpc-js": "~1.6.0", | ||
| "google-gax": "file:./google-gax.tgz", | ||
| "google-gax": "^6.0.0", |
There was a problem hiding this comment.
The dependency on google-gax in this test application was incorrectly changed from a local tarball reference (file:./google-gax.tgz) to a registry version (^6.0.0). These tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "google-gax": "^6.0.0", | |
| "google-gax": "file:./google-gax.tgz", |
| "showcase-echo-client": "^0.0.1", | ||
| "showcase-server": "^0.0.1-security" |
There was a problem hiding this comment.
The dependencies on showcase-echo-client and showcase-server in this test application were incorrectly changed from local tarball references to registry versions. These tests must use the local tarballs to ensure that the local, modified code is being tested rather than the published versions from the npm registry.
| "showcase-echo-client": "^0.0.1", | |
| "showcase-server": "^0.0.1-security" | |
| "showcase-echo-client": "./showcase-echo-client.tgz", | |
| "showcase-server": "./showcase-server.tgz" |
| }, | ||
| "dependencies": { | ||
| "gcp-metadata": "file:./gcp-metadata.tgz" | ||
| "gcp-metadata": "^9.0.0" |
There was a problem hiding this comment.
The dependency on gcp-metadata in this cloudbuild test fixture was incorrectly changed from a local tarball reference (file:./gcp-metadata.tgz) to a registry version (^9.0.0). These tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "gcp-metadata": "^9.0.0" | |
| "gcp-metadata": "file:./gcp-metadata.tgz" |
| }, | ||
| "dependencies": { | ||
| "gcp-metadata": "file:./gcp-metadata.tgz" | ||
| "gcp-metadata": "^9.0.0" |
There was a problem hiding this comment.
The dependency on gcp-metadata in this hook test fixture was incorrectly changed from a local tarball reference (file:./gcp-metadata.tgz) to a registry version (^9.0.0). These tests must use the local tarball to ensure that the local, modified code is being tested rather than the published version from the npm registry.
| "gcp-metadata": "^9.0.0" | |
| "gcp-metadata": "file:./gcp-metadata.tgz" |
This reverts commit 44193ad.
…/googleapis/google-cloud-node into node-22-upgrade-all-dependencies # Conflicts: # handwritten/logging/package.json
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕