fix(linter): update ESLint extends path in handwritten packages - #9080
Draft
westarle wants to merge 1 commit into
Draft
fix(linter): update ESLint extends path in handwritten packages#9080westarle wants to merge 1 commit into
westarle wants to merge 1 commit into
Conversation
In handwritten packages, .eslintrc.json previously specified "extends": "./node_modules/gts". In the monorepo CI linter workflow, dependencies (node_modules/gts) are installed only at the root of the monorepo and not in individual package subdirectories. When bin/linter.mjs --strict runs on changed TypeScript files in a handwritten package, ESLint resolves ./node_modules/gts relative to the package directory (handwritten/<pkg>/node_modules/gts), which fails with: Failed to load config "./node_modules/gts" to extend from. Cannot read properties of undefined (reading 'fileExists') Update "extends": "./node_modules/gts" to "extends": "../../node_modules/gts" across all 15 packages in handwritten/ so ESLint can resolve gts from the monorepo root.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ESLint configuration files across multiple packages under the handwritten directory, changing the extended path for GTS from './node_modules/gts' to '../../node_modules/gts' to correctly reference the root node_modules. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In handwritten packages, .eslintrc.json previously specified "extends": "./node_modules/gts". In the monorepo CI linter workflow, dependencies (node_modules/gts) are installed only at the root of the monorepo and not in individual package subdirectories.
When bin/linter.mjs --strict runs on changed TypeScript files in a handwritten package, ESLint resolves ./node_modules/gts relative to the package directory (handwritten//node_modules/gts), which fails with:
Failed to load config "./node_modules/gts" to extend from.
Cannot read properties of undefined (reading 'fileExists')
Update "extends": "./node_modules/gts" to "extends": "../../node_modules/gts" across all 15 packages in handwritten/ so ESLint can resolve gts from the monorepo root.