fix(ci): improve changed file detection in linter script by shivanee-p · Pull Request #8968 · googleapis/google-cloud-node

shivanee-p · 2026-07-24T22:13:19Z

Fixes an issue where ./bin/linter.mjs skipped TypeScript checks in CI pull request workflows because it's incorrectly detecting no TS file changes. Updates linter logic to be hermetic.

It looks like the CI was comparing "head" to "head". It was running git diff FETCH_HEAD -- *.ts, but we need to fetch from origin before doing that. Previously, the linter was going in order of the refsToTry array to check which reference existed in order to diff against it:

main, upstream/main, and origin/main failed
'FETCH_HEAD', existed and pointed to the checked-out PR commit (HEAD).
Running git diff --name-only FETCH_HEAD -- *.ts compared HEAD against itself, which succeeded with an exit code of 0 and returned an empty file list ("")

Fixes:

Removed git fetch calls so the script relies solely on local Git history provided by actions/checkout.
Added STRICT mode to ./bin/linter.mjs, configured in presubmit.yaml
Uses git merge-base to accurately identify changed files when both main and the branch have moved.
Fails explicitly in CI if GITHUB_BASE_REF is missing or invalid, or if the GIT_DIFF_ARG is missing in STRICT mode
Streamlined reference resolution for local development and added logging for the chosen base reference.

gemini-code-assist

Code Review

This pull request updates the linter script to fetch the base branch when running in a GitHub Actions environment and refactors the list of Git references used to determine changed files. The reviewer suggested using an explicit refspec in the git fetch command to ensure the remote-tracking branch is correctly created and updated in shallow-clone CI environments.

shivanee-p · 2026-07-24T22:19:38Z

/gemini

gemini-code-assist · 2026-07-24T22:19:55Z

Hello! It looks like you've invoked me to help with this pull request. Since you didn't specify a command, I've provided a summary of your changes below.

Pull Request Summary: `fix(ci): improve changed file detection in linter script`

This PR addresses a critical issue in bin/linter.mjs where the linter was failing to detect changed TypeScript files in CI environments.

Key Changes:

Explicit Fetching: Added logic to fetch the base branch (origin/${base}) with --depth=1 when running in CI. This ensures the remote reference is available locally for comparison.
Improved Diff Strategy: Updated refsToTry to prioritize triple-dot (...) diffs, which correctly identify the common ancestor between the target branch and the feature branch.
Cleanup: Removed FETCH_HEAD from the candidate references to prevent the linter from accidentally comparing HEAD against itself in shallow clones.

These changes should significantly improve the reliability of your CI linter checks. If you would like a detailed code review, please feel free to run /gemini review.

…ef detection

…ibility

…gedFilesStrict

Reverts #8968 until we can get the linter working correctly for handwritten libraries.

Fixes an issue where `./bin/linter.mjs` skipped TypeScript checks in CI pull request workflows because it's incorrectly detecting no TS file changes. Updates linter logic to be hermetic. It looks like the CI was comparing "head" to "head". It was running `git diff FETCH_HEAD -- *.ts`, but we need to fetch from origin before doing that. Previously, the linter was going in order of the `refsToTry` array to check which reference existed in order to diff against it: 1. `main`, `upstream/main`, and `origin/main` failed 2. `'FETCH_HEAD'`, existed and pointed to the checked-out PR commit (`HEAD`). 3. Running `git diff --name-only FETCH_HEAD -- *.ts` compared `HEAD` against itself, which succeeded with an exit code of `0` and returned an empty file list (`""`) Fixes: - Removed git fetch calls so the script relies solely on local Git history provided by actions/checkout. - Added `STRICT` mode to ./bin/linter.mjs, configured in presubmit.yaml - Uses git merge-base to accurately identify changed files when both main and the branch have moved. - Fails explicitly in CI if GITHUB_BASE_REF is missing or invalid, or if the GIT_DIFF_ARG is missing in STRICT mode - Streamlined reference resolution for local development and added logging for the chosen base reference.

Reverts #8968 until we can get the linter working correctly for handwritten libraries.

shivanee-p requested a review from a team as a code owner July 24, 2026 22:13

gemini-code-assist Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread bin/linter.mjs Outdated

shivanee-p force-pushed the shivaneep-linter-diff-logic branch from a449965 to 2a57889 Compare July 24, 2026 22:18

shivanee-p requested review from a team as code owners July 27, 2026 17:31

shivanee-p removed request for a team July 27, 2026 17:36

shivanee-p force-pushed the shivaneep-linter-diff-logic branch 2 times, most recently from 88c3e97 to ee44be0 Compare July 27, 2026 17:44

shivanee-p requested review from a team as code owners July 27, 2026 17:44

shivanee-p force-pushed the shivaneep-linter-diff-logic branch from 76b0942 to 480b5d0 Compare July 27, 2026 17:59

shivanee-p requested review from danieljbruce and removed request for a team July 27, 2026 18:01

shivanee-p force-pushed the shivaneep-linter-diff-logic branch from 0c3abfe to fd5e150 Compare July 27, 2026 20:33

shivanee-p removed the request for review from a team July 27, 2026 21:31

westarle reviewed Jul 29, 2026

View reviewed changes

Comment thread bin/linter.mjs Outdated

Comment thread bin/linter.mjs

Comment thread bin/linter.mjs

Comment thread bin/linter.mjs Outdated

shivanee-p force-pushed the shivaneep-linter-diff-logic branch from fd5e150 to 3c88044 Compare July 30, 2026 21:38

shivanee-p requested review from westarle and removed request for danieljbruce July 31, 2026 18:57

shivanee-p force-pushed the shivaneep-linter-diff-logic branch 2 times, most recently from 15bc305 to 56e9aea Compare July 31, 2026 20:06

westarle requested changes Jul 31, 2026

View reviewed changes

Comment thread bin/linter.mjs Outdated

Comment thread bin/linter.mjs Outdated

shivanee-p added a commit that referenced this pull request Aug 3, 2026

revert(linter): restore getChangedFiles implementation from PR #8968

034523e

shivanee-p added 20 commits August 3, 2026 15:13

fix(ci): improve changed file detection in linter script

7575e5b

fix(ci): use explicit refspec when fetching base branch

00944ff

fix(linter): use namespace import for typescript ESM compatibility

70084ee

fix(linter): make changed file resolution hermetic and improve base r…

ba23899

…ef detection

fix(linter): use default import for typescript in ESM module

d795744

fix(linter): check remote main refs before HEAD~1 when on main branch

290434b

refactor(linter): consolidate getChangedFiles reference resolution logic

b0accfe

chore(linter): clean up comments and format branch check in linter.mjs

e2c5ef3

fix(linter): resolve origin/baseRef in CI for actions/checkout compat…

49c80ce

…ibility

feat(linter): add --strict mode changed file detection

5b42816

fix(ci): fetch base branch in presubmit workflow for strict linter diff

3db57ca

refactor(linter): use environment variables for strict mode diff logic

da4b704

style(linter): clean up unused space in getChangedFiles()

28667f2

refactor(linter): simplify getChangedFiles for default non-strict mode

409044a

refactor(linter): inline process.env.GIT_DIFF_ARG directly in getChan…

fd811c9

…gedFilesStrict

refactor(linter): use git diff ref...HEAD directly in getChangedFiles

00807c3

fix(linter): align strict mode CI diff logic with PR #9021

384a079

revert(linter): restore getChangedFiles implementation from PR #8968

3c3bd25

refactor(linter): clean up strict mode handling and flags

585034e

style(linter): remove empty line in getChangedFiles

21bad2f

shivanee-p force-pushed the shivaneep-linter-diff-logic branch from ba2276d to 21bad2f Compare August 3, 2026 22:13

shivanee-p enabled auto-merge (squash) August 3, 2026 22:14

shivanee-p merged commit caf65f3 into main Aug 3, 2026
34 checks passed

shivanee-p deleted the shivaneep-linter-diff-logic branch August 3, 2026 22:22

westarle mentioned this pull request Aug 4, 2026

fix(ci): revert improve changed file detection in linter script #9081

Merged

westarle added a commit that referenced this pull request Aug 4, 2026

fix(ci): revert improve changed file detection in linter script (#9081)

1b6992b

Reverts #8968 until we can get the linter working correctly for handwritten libraries.

shivanee-p pushed a commit that referenced this pull request Aug 4, 2026

fix(ci): revert improve changed file detection in linter script (#9081)

daf8283

Reverts #8968 until we can get the linter working correctly for handwritten libraries.

shivanee-p mentioned this pull request Aug 4, 2026

chore: linter eslint fix #9088

Open

Navigation Menu

Uh oh!

fix(ci): improve changed file detection in linter script - #8968

fix(ci): improve changed file detection in linter script#8968
shivanee-p merged 20 commits into
mainfrom
shivaneep-linter-diff-logic

shivanee-p commented Jul 24, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

shivanee-p commented Jul 24, 2026

Uh oh!

gemini-code-assist Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shivanee-p commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

shivanee-p commented Jul 24, 2026

Uh oh!

gemini-code-assist Bot commented Jul 24, 2026

Pull Request Summary: fix(ci): improve changed file detection in linter script

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shivanee-p commented Jul 24, 2026 •

edited

Loading

Pull Request Summary: `fix(ci): improve changed file detection in linter script`