fix: bump protobufjs handwritten/* dependencies to address vulnerabilities#8652
Open
pearigee wants to merge 2 commits into
Open
fix: bump protobufjs handwritten/* dependencies to address vulnerabilities#8652pearigee wants to merge 2 commits into
pearigee wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the protobufjs dependency to ^7.6.4 and protobufjs-cli to ^1.3.3 across multiple package.json files in the repository. The review feedback points out a potential peer dependency conflict in handwritten/bigquery-storage/package.json, where the peerDependencies range for protobufjs is more restrictive (~7.6.4) than the dependencies range (^7.6.4), and suggests aligning them to prevent warnings for consumers.
MarkDuckworth
approved these changes
Jun 15, 2026
MarkDuckworth
left a comment
Contributor
There was a problem hiding this comment.
LGTM - firestore. But also other packages look good.
alkatrivedi
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of new vulnerabilities in protobufjs were discovered in May:
https://github.com/advisories?query=protobufjs
New versions of this package have been released (as recently as last week). This PR explicitly bumps each package to its most recent minor version.