perf(spanner): optimize decoding of large result sets#8454
Open
olavloite wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces performance optimizations for decoding Spanner values, including fast-path parsing for YYYY-MM-DD date strings and RFC 3339 timestamps, compiling specialized cell decoding closures, and caching decoders in PartialResultStream. Feedback highlights two critical issues: first, the fast-path date parser in SpannerDate uses the local timezone instead of UTC, which can lead to off-by-one errors; second, the fallback logic for struct fields in createDecoder incorrectly handles falsy values, potentially resulting in data loss.
…gle-cloud-node into spanner-optimize-decoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimizes row decoding for large result sets for the Spanner client by determining the type of decoder that should be used once, and then reuse that for each row. Also optimizes some of the specific decoders to use a fast-path option for the most common cases (e.g. valid DATE and TIMESTAMP strings).