chore: initial Librarian migration#8453
Conversation
Adds librarian.yaml to the root of the repository, with all libraries skipped initially. Also updates the release-please configuration to use the new node-librarian strategy, which updates the version numbers in librarian.yaml.
There was a problem hiding this comment.
Code Review
This pull request introduces a new librarian.yaml configuration file defining various Google Cloud Node.js libraries and updates the release type in release-please-config.json to node-librarian. The review feedback points out several libraries in librarian.yaml that are missing their explicit npm package_name under the nodejs block, providing code suggestions to add the correct package names.
| nodejs: | ||
| nodejs_apis: | ||
| - omit_common_resources: true | ||
| path: google/cloud/advisorynotifications/v1 |
There was a problem hiding this comment.
The npm package name for google-cloud-advisorynotifications is @google-cloud/advisory-notifications. Please specify the correct package_name under the nodejs block.
nodejs:
package_name: '@google-cloud/advisory-notifications'
nodejs_apis:
- omit_common_resources: true
path: google/cloud/advisorynotifications/v1| apis: | ||
| - path: google/cloud/rapidmigrationassessment/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-rapidmigrationassessment is @google-cloud/rapid-migration-assessment. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/rapid-migration-assessment'| apis: | ||
| - path: google/cloud/securesourcemanager/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-securesourcemanager is @google-cloud/secure-source-manager. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/secure-source-manager'| apis: | ||
| - path: google/cloud/securitycentermanagement/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-securitycentermanagement is @google-cloud/security-center-management. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/security-center-management'| apis: | ||
| - path: google/cloud/servicehealth/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-servicehealth is @google-cloud/service-health. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/service-health'| - path: google/cloud/telcoautomation/v1 | ||
| - path: google/cloud/telcoautomation/v1alpha1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-telcoautomation is @google-cloud/telco-automation. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/telco-automation'| - path: google/cloud/visionai/v1 | ||
| - path: google/cloud/visionai/v1alpha1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-visionai is @google-cloud/vision-ai. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/vision-ai'| apis: | ||
| - path: google/cloud/vmmigration/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-vmmigration is @google-cloud/vm-migration. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/vm-migration'| apis: | ||
| - path: google/cloud/vmwareengine/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-vmwareengine is @google-cloud/vmware-engine. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/vmware-engine'| apis: | ||
| - path: google/cloud/workloadmanager/v1 | ||
| copyright_year: "2026" | ||
| skip_generate: true |
There was a problem hiding this comment.
The npm package name for google-cloud-workloadmanager is @google-cloud/workload-manager. Please specify the correct package_name under the nodejs block.
skip_generate: true
nodejs:
package_name: '@google-cloud/workload-manager'|
@quirogas This was just the default migrate tool (tweaked a tiny bit to skip generation) - do you have any thoughts around the Gemini comments? (We can tweak these manually rather than changing the migrate tool.) |
Adds librarian.yaml to the root of the repository, with all libraries skipped initially. Also updates the release-please configuration to use the new node-librarian strategy, which updates the version numbers in librarian.yaml.