feat(auth): Skip RAB lookup if MDS returns a non-email.#8440
Open
vverman wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the getRegionalAccessBoundaryUrl method in the Compute client to validate the format of the service account email, returning null if it is invalid or missing. It also adds comprehensive unit tests to verify this behavior. The feedback suggests moving the regular expression definition to a module-level constant to avoid recreating it on every function call, which improves performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In computeclient.ts, the resolveServiceAccountEmail function could return a non-email.
In such cases, we skip RAB lookup, log the skip once for user and avoid making any future MDS calls.
Added tests for this.