Skip to content

chore: eliminate test run.ts#8414

Open
quirogas wants to merge 24 commits into
googleapis:mainfrom
quirogas:chore/eliminate-test-run-ts
Open

chore: eliminate test run.ts#8414
quirogas wants to merge 24 commits into
googleapis:mainfrom
quirogas:chore/eliminate-test-run-ts

Conversation

@quirogas
Copy link
Copy Markdown
Contributor

@quirogas quirogas commented Jun 2, 2026

Eliminate the handwritten test runners (test/run.ts) from major packages like google-cloud-compute, google-cloud-dialogflow-cx, and google-cloud-aiplatform to remove the maintenance of the handwritten test files. It standardizes package.json test configurations monorepo-wide to use the root unified .mocharc.cjs configuration, and integrates the new shared batch runner for google-cloud-compute to reduce memory load during execution.

For #librarian/4583
For #librarian/5960

@quirogas quirogas self-assigned this Jun 2, 2026
@quirogas quirogas changed the title Chore/eliminate test run ts chore: eliminate test run.ts Jun 2, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes the Mocha test configuration by removing package-specific .mocharc.js files and updating package.json test scripts across the monorepo to reference a shared root configuration. It also increases the Node memory limit in the CI script. The review feedback highlights critical issues with the shared .mocharc.js changes: switching to ES module export syntax (export default) breaks CommonJS compatibility, and replacing the recursive option with parallel prevents nested test discovery. Additionally, several package test scripts, such as those in google-cloud-dialogflow and google-cloud-discoveryengine, are missing the shared configuration argument in their secondary or fallback Mocha invocations.

Comment thread .mocharc.js
Comment thread .mocharc.cjs
Comment thread packages/google-cloud-dialogflow/package.json Outdated
Comment thread packages/google-cloud-discoveryengine/package.json Outdated
quirogas added 17 commits June 2, 2026 16:15
…able map test to support unified mocharc.cjs
@quirogas quirogas marked this pull request as ready for review June 3, 2026 18:22
@quirogas quirogas requested a review from a team as a code owner June 3, 2026 18:22
@quirogas quirogas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants