chore: disable system tests in packages to unblock PRs pending fix#7974
Merged
chore: disable system tests in packages to unblock PRs pending fix#7974
Conversation
quirogas
approved these changes
Apr 7, 2026
Contributor
quirogas
left a comment
There was a problem hiding this comment.
Should we add a comment explaining why we are skipping these tests. Or maybe we could add a TODO to revert this change later.
This can be tracked via the commit history, either way, so up it's up to you.
Contributor
Author
|
Absolutely, thanks. I was just working with @shivanee-p to write an issue we can reference. I will update this PR with a link/comment shortly. |
Contributor
Author
|
Note in #7921, we are considering deleting these tests all together. This may be a good first step in that direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System tests are failing with the following error:
(for example: https://github.com/googleapis/google-cloud-node/pull/7961/checks?check_run_id=70274525122)
Note, this was already fixed in the generator in #7943. However, the generator release takes some time (i.e. days). This is meant to unblock PRs immediately.
See the system test failures here:
#7976
On a side note, these system tests seem to add very little value. The generated system tests just create the client and then close it. Furthermore, for generated libraries, we expect them to work by default. We don't manually update these libraries, so the need for regression testing is minimal.