chore: fix system tests using pack-n-play when running JS#7970
Open
chore: fix system tests using pack-n-play when running JS#7970
Conversation
Contributor
Author
|
/gcbrun |
…EXCEEDED error in service
quirogas
approved these changes
Apr 7, 2026
Contributor
quirogas
left a comment
There was a problem hiding this comment.
The change looks good to me, let's just make sure the GCB test pass before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System tests are failing with the following error:
(for example: https://github.com/googleapis/google-cloud-node/pull/7961/checks?check_run_id=70274525122)
At the moment, the system tests are configured to run the JavaScript test as if it were TypeScript:
This PR simply updates the tests to instead run
index.jsas a CJS artifact:Note, this was already fix in the generator in #7943. However, the generator release takes some time (i.e. days). This is meant to unblock PRs immediately.