Repository navigation
chore: add test for new client generation - #8670
Merged
Merged
Conversation
meltsufin
force-pushed
the
gh-action-newclient
branch
2 times, most recently
from
October 23, 2022 21:33
a8da0ea to
80d3706
Compare
meltsufin
force-pushed
the
gh-action-newclient
branch
from
October 24, 2022 01:29
f74563f to
d1d9dd2
Compare
Member
How about yoshi-code-bot account? https://github.com/googleapis/google-cloud-java/blob/main/.github/workflows/readme.yaml#L35 (I don't know its entitlement) |
Contributor
Author
Doesn't seem to be working either. |
meltsufin
force-pushed
the
gh-action-newclient
branch
from
October 26, 2022 03:46
123c243 to
40cd445
Compare
meltsufin
marked this pull request as ready for review
October 26, 2022 22:49
suztomo
reviewed
Oct 27, 2022
Comment on lines
+49
to
+58
| - name: Push to branch | ||
| run: | | ||
| [ -z "`git config user.email`" ] && git config --global user.email "${USERNAME:-script}@google.com" | ||
| [ -z "`git config user.name`" ] && git config --global user.name "${USERNAME:-script}" | ||
| git checkout -b newclient_output_${{ github.event_name }} | ||
| git add --all | ||
| git commit -m 'feat: re-generated apikeys' | ||
| git remote add monorepo https://${{ github.actor }}:${{ github.token }}@github.com/${{ github.repository }}.git | ||
| git fetch -q --unshallow monorepo | ||
| git push -f monorepo newclient_output_${{ github.event_name }} |
Member
There was a problem hiding this comment.
How does "Push to branch" help verify the behavior of new-client.py?
Contributor
Author
There was a problem hiding this comment.
It's just there for debugging, in case the job fails.
Member
|
How might we verify new-client.py’s logic of adding a corresponding new entry to gapic BOM, release please configuration files, and the root pom.xml? |
suztomo
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8659