Skip to content

fix(java-notebooks): ITNotebookServiceClientTest.testGetEnvironment now performs valid assertions. Add copyright to Util.java. - #8402

Closed
burkedavison wants to merge 2 commits into
mainfrom
fix-java-notebooks-testGetEnvironment
Closed

fix(java-notebooks): ITNotebookServiceClientTest.testGetEnvironment now performs valid assertions. Add copyright to Util.java.#8402
burkedavison wants to merge 2 commits into
mainfrom
fix-java-notebooks-testGetEnvironment

Conversation

@burkedavison

Copy link
Copy Markdown
Member

Resolves checkstyle failure on this project, and ensures the test is performing useful assertions.

@meltsufin

meltsufin commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

@suztomo I thought I saw the postprocessor take care of copyright headers in some repos. Does it ring a bell?

@suztomo

suztomo commented Sep 15, 2022

Copy link
Copy Markdown
Member

Strange. The Util.java doesn't exist in the java-notebooks repository.

https://github.com/googleapis/java-notebooks/tree/main/google-cloud-notebooks/src/test/java/com/google/cloud/notebooks/v1beta1/it

@suztomo

suztomo commented Sep 15, 2022

Copy link
Copy Markdown
Member

@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2022
@burkedavison
burkedavison deleted the fix-java-notebooks-testGetEnvironment branch October 26, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants