Skip to content

gcloud-datastore-emulator version 1.2.0 raising DatastoreException #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Juroviol wants to merge 2 commits into from
Closed

gcloud-datastore-emulator version 1.2.0 raising DatastoreException #3181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c99f3f
Update BaseEmulatorHelper.java
Juroviol Apr 21, 2018
37f3365
Update LocalDatastoreHelper.java
Juroviol Apr 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google-cloud-core/src/main/java/com/google/cloud/testing/BaseEmulatorHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public Process getProcess() {
private boolean isGcloudInstalled() {
Map<String, String> env = System.getenv();
for (String envName : env.keySet()) {
if ("PATH".equals(envName)) {
if ("PATH".equalsIgnoreCase(envName)) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

return env.get(envName).contains("google-cloud-sdk");
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...loud-datastore/src/main/java/com/google/cloud/datastore/testing/LocalDatastoreHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public class LocalDatastoreHelper extends BaseEmulatorHelper<DatastoreOptions> {
private static final String GCLOUD_CMD_TEXT = "gcloud beta emulators datastore start";
private static final String GCLOUD_CMD_PORT_FLAG = "--host-port=";
private static final String VERSION_PREFIX = "cloud-datastore-emulator ";
private static final String MIN_VERSION = "1.2.0";
private static final String MIN_VERSION = "1.4.0";

// Downloadable emulator settings
private static final String BIN_NAME = "cloud-datastore-emulator/cloud_datastore_emulator";
Expand Down