Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request configures the CLIRR plugin within a profile in the Google Auth Library, replaces the unlicensed isorelax dependency with org.netbeans.external:isorelax across several POM files, pins the maven-surefire-plugin to version 3.5.3, and updates the libraries-bom version in samples. Feedback suggests also pinning the maven-failsafe-plugin to the same version (3.5.3) in both the root and dashboard POMs to avoid potential classpath or test runner conflicts.
org.netbeans.external:isorelax replaces isorelax:isorelax as a runtime dependency of com.google.cloud.tools:dependencies. No code in the java-cloud-bom tooling modules uses it directly, so .kokoro/dependencies.sh (dependency:analyze -DfailOnWarning=true) reports it as an unused declared dependency. Add it to ignoredUnusedDeclaredDependencies in the 5 analyzed modules.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares
google-cloud-javaandjava-cloud-bomto build and release using only dependencies from the Airlock trusted Maven repository (maven-3p-trusted).Changes
isorelax:isorelax:20030108withorg.netbeans.external:isorelax:RELEASE310in 7 internal tooling POMs (java-cloud-bom/{dashboard,libraries-release-data,release-note-generation,tests,tests/validate-bom}andsdk-platform-java/java-shared-dependencies/{dependency-convergence-check,unmanaged-dependency-check}):isorelax:isorelax:20030108(transitively pulled bycom.google.cloud.tools:dependencies) has no license metadata in its POM or source repository.isorelax:isorelaxand replaces it withorg.netbeans.external:isorelax:RELEASE310(MIT license, identicalorg.iso_relaxJARV API, available inmaven-3p-trusted).clirr-maven-plugininto theclirr-compatibility-checkprofile ingoogle-auth-library-java/pom.xml:clirr-maven-pluginbinding in a JDK-activatedclirr-compatibility-checkprofile matchingjava-shared-config.-P=-clirr-compatibility-check) to skip resolvingplexus-components:1.1.4andclassworlds:1.1-alpha-2.maven-surefire-plugin:3.5.3injava-cloud-bom/pom.xmlandjava-cloud-bom/dashboard/pom.xml:maven-surefire-plugin:2.17and inherited2.22.2so thejava-cloud-bomrelease build stops pullingclassworlds:1.1,classworlds:1.1-alpha-2, andslf4j-api:1.5.6.<module>tests/dependency-convergence</module>from the defaultjava-cloud-bom/pom.xmlreactor:java-cloud-bomrelease reactor from resolving every newly published 1P artifact from the same-day release train before Airlock finishes importing them. CI (.kokoro/dashboard.sh) runsdependency-convergence-checkseparately.libraries-bomto26.90.0injava-samples/native-image-sample/pom.xmlandjava-spanner/samples/snippets/pom.xml:libraries-bomimports (26.80.0and26.84.0) that pullgoogle-cloud-bom:0.261.0and0.265.0with26.90.0(google-cloud-bom:0.271.0, available inmaven-3p-trusted).