Skip to content

test: add internal testing flag back - #14079

Merged
mutianf merged 2 commits into
googleapis:mainfrom
mutianf:ff
Aug 14, 2026
Merged

test: add internal testing flag back#14079
mutianf merged 2 commits into
googleapis:mainfrom
mutianf:ff

Conversation

@mutianf

@mutianf mutianf commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mutianf
mutianf requested review from a team as code owners August 14, 2026 15:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures the client builder to set the sessions-required property using the internal system property 'bigtable.internal.sessions-required'. Feedback was provided to correct a minor grammatical typo in the inline comment explaining this change.

Comment on lines +82 to +84
.setSessionsRequired( // Internal system property internal testing, not to be used by
// external customers.
Boolean.getBoolean("bigtable.internal.sessions-required"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment contains a grammatical typo: "Internal system property internal testing". It should be "Internal system property for internal testing".

Suggested change
.setSessionsRequired( // Internal system property internal testing, not to be used by
// external customers.
Boolean.getBoolean("bigtable.internal.sessions-required"))
.setSessionsRequired( // Internal system property for internal testing, not to be used by
// external customers.
Boolean.getBoolean("bigtable.internal.sessions-required"))

@mutianf
mutianf enabled auto-merge (squash) August 14, 2026 16:10
@mutianf
mutianf merged commit 82434dd into googleapis:main Aug 14, 2026
205 of 209 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants