Skip to content

FEAT: rewire bigtable.internal.sessions-required system property #14078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neilw4 wants to merge 1 commit into from
+8 −3
Closed

FEAT: rewire bigtable.internal.sessions-required system property #14078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...main/java/com/google/cloud/bigtable/data/v2/internal/util/ClientConfigurationManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,15 +410,20 @@ private ClientConfiguration normalizeConfig(ClientConfiguration cfg) {
// cfg, so that a nonzero session_load supplied via the override sys-prop is honoured even when
// the server-returned config has session_load=0.
if (builder.getSessionConfiguration().getSessionLoad() == 0) {
builder.clearSessionConfiguration();
return builder.build();
if (Boolean.getBoolean("bigtable.internal.sessions-required")) {

@gemini-code-assist gemini-code-assist Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The system property key "bigtable.internal.sessions-required" is duplicated here and on line 425. Consider defining a constant for the property name to improve maintainability. Note that caching system properties or environment variables in class fields is unnecessary if they are only evaluated once during object initialization.

References
  1. Avoid caching system properties or environment variables in class fields if they are only evaluated once during object initialization, as caching is unnecessary in such cases.

builder.getSessionConfigurationBuilder().setSessionLoad(1.0f);
} else {
builder.clearSessionConfiguration();
return builder.build();
}
}

return builder.build();
}

public boolean areSessionsRequired() {
return overrideConfig.map(c -> c.getSessionConfiguration().getSessionLoad() > 0).orElse(false);
return Boolean.getBoolean("bigtable.internal.sessions-required")
|| overrideConfig.map(c -> c.getSessionConfiguration().getSessionLoad() > 0).orElse(false);
}

private long getRetryDelay(int attempt) {
Expand Down
Loading