Skip to content

fix(gax): implement getMessage() in FlowController exceptions #14077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NiranjanKumar001 wants to merge 9 commits into
base: main
Choose a base branch
from
+19 −13
Open

fix(gax): implement getMessage() in FlowController exceptions #14077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
068c4d6
fix(gax): implement getMessage() in FlowController exceptions
NiranjanKumar001 Aug 14, 2026
0aed6f9
refactor: pass detail message to super constructor per code review
NiranjanKumar001 Aug 14, 2026
d6faa34
Update sdk-platform-java/gax-java/gax/src/main/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
1513241
Update sdk-platform-java/gax-java/gax/src/main/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
9fb09de
Update sdk-platform-java/gax-java/gax/src/main/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
36db8f2
Update sdk-platform-java/gax-java/gax/src/test/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
e7a8763
Update sdk-platform-java/gax-java/gax/src/test/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
c29d9e3
Update sdk-platform-java/gax-java/gax/src/test/java/com/google/api/ga…
NiranjanKumar001 Aug 14, 2026
730a949
refactor: remove unused no-arg constructor and replace String.format …
NiranjanKumar001 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/batching/FlowController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@
public class FlowController {
/** Base exception that signals a flow control state. */
public abstract static class FlowControlException extends Exception {
private FlowControlException() {}
private FlowControlException(String message) {
super(message);
}
}

/**
Expand All @@ -68,18 +70,13 @@ public static final class MaxOutstandingElementCountReachedException
private final long currentMaxElementCount;

public MaxOutstandingElementCountReachedException(long currentMaxElementCount) {
super("The maximum number of batch elements: " + currentMaxElementCount + " has been reached.");
this.currentMaxElementCount = currentMaxElementCount;
}

public long getCurrentMaxBatchElementCount() {
return currentMaxElementCount;
}

@Override
public String toString() {
return String.format(
"The maximum number of batch elements: %d have been reached.", currentMaxElementCount);
}
}

/**
Expand All @@ -91,18 +88,13 @@ public static final class MaxOutstandingRequestBytesReachedException
private final long currentMaxBytes;

public MaxOutstandingRequestBytesReachedException(long currentMaxBytes) {
super("The maximum number of batch bytes: " + currentMaxBytes + " has been reached.");
this.currentMaxBytes = currentMaxBytes;
}

public long getCurrentMaxBatchBytes() {
return currentMaxBytes;
}

@Override
public String toString() {
return String.format(
"The maximum number of batch bytes: %d have been reached.", currentMaxBytes);
}
}

/**
Expand Down
14 changes: 14 additions & 0 deletions ...tform-java/gax-java/gax/src/test/java/com/google/api/gax/batching/FlowControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,4 +774,18 @@ private List<Future<?>> testConcurrentUpdates(
executors.shutdown();
return reserveReleaseFuture;
}

@Test
public void testExceptionGetMessage() {
FlowController.MaxOutstandingElementCountReachedException elementException =
new FlowController.MaxOutstandingElementCountReachedException(100);
assertThat(elementException.getMessage())
.isEqualTo("The maximum number of batch elements: 100 has been reached.");

FlowController.MaxOutstandingRequestBytesReachedException bytesException =
new FlowController.MaxOutstandingRequestBytesReachedException(500);
assertThat(bytesException.getMessage())
.isEqualTo("The maximum number of batch bytes: 500 has been reached.");
}
}

Loading