ci: quick-build profile skip shading - #14046
Open
lqiu96 wants to merge 8 commits into
Open
Conversation
Heavy shading in gapic-generator-java and spanner-jdbc unpacks and repackages hundreds of megabytes of classes, taking >15 minutes in CI. Configure 'skipShade' property in parent POMs and gapic-generator-java to skip shading during quick-build reactor installations.
Use shade.skip to match Maven Shade Plugin's native user property and standard codebase conventions (checkstyle.skip, enforcer.skip, fmt.skip, etc.).
Add shade.skip=true to the quick-build profile in parent POMs to skip heavy shading during fast reactor installations.
Contributor
There was a problem hiding this comment.
Code Review
This pull request attempts to skip shading during quick builds by adding a skip property to several pom.xml files. However, the reviewer correctly pointed out that the standard property to skip the maven-shade-plugin is maven.shade.skip instead of shade.skip. Using shade.skip will not be recognized by the plugin, meaning shading would not actually be skipped.
Maven Shade Plugin's skip parameter does not declare a built-in property expression in its Mojo descriptor, so explicit mapping via <skip>${shade.skip}</skip> is required for the profile property to take effect.
Document why shade.skip property is declared and mapped explicitly. Default shade.skip to false so normal builds continue shading, while quick-build toggles it to true.
Add <skip>${shade.skip}</skip> to maven-shade-plugin configurations in:
- java-bigquery/benchmark
- java-bigtable (and test-proxy)
- java-storage-nio/google-cloud-nio
- java-storage/storage-shared-benchmarking
lqiu96
marked this pull request as ready for review
August 11, 2026 21:06
|
|
jinseopkim0
approved these changes
Aug 11, 2026
Keep gapic-generator-java shaded so its executable protoc plugin binary remains functional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing this weird issue in the enforcer plugin:
Gemini is suggesting that not shading may end up speeding up some of the longer to build modules:
Try it out to see if running in the CIs via
quick-buildprofile can help. Shading will continue to be run, but only skipped in the quick-build profile.EDIT: Looks like we have to shade the generator for now