feat(google/cloud/sql): onboard a new library#13864
Conversation
There was a problem hiding this comment.
Code Review
This pull request onboards the auto-generated Google Cloud SQL Admin Client for Java (java-sql module), including the client libraries, BOM, metadata, and GAPIC code. The reviewer identified a critical issue where the parent POM (google-cloud-sql-parent) is missing from the PR, which will cause Maven build failures. Additionally, the product_documentation field in .repo-metadata.json is empty, leading to broken links in the generated README.md. It is recommended to add the missing parent POM and update the metadata before regenerating the README.
| <description>Cloud SQL Admin Cloud SQL Admin API</description> | ||
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-sql-parent</artifactId> |
There was a problem hiding this comment.
The parent POM is configured as google-cloud-sql-parent, but this parent POM file (typically java-sql/pom.xml or java-sql/google-cloud-sql-parent/pom.xml) is not included in this pull request. If java-sql is a new module, the parent POM must be onboarded in this PR as well, otherwise the Maven build will fail due to the missing parent POM dependency. Please add the parent POM to this pull request.
| { | ||
| "api_shortname": "sqladmin", | ||
| "name_pretty": "Cloud SQL Admin", | ||
| "product_documentation": "", |
There was a problem hiding this comment.
The product_documentation field is currently empty. This metadata is used by the generator to populate the product documentation links in the generated README.md (which currently has a broken/empty link reference [product-docs]: at the bottom of the file). Please populate this field with the correct Cloud SQL Admin product documentation URL (e.g., https://cloud.google.com/sql/docs).
| "product_documentation": "", | |
| "product_documentation": "https://cloud.google.com/sql/docs", |
References
- Modify the generator or the source metadata instead of manually editing auto-generated files.
|
|
||
| Java is a registered trademark of Oracle and/or its affiliates. | ||
|
|
||
| [product-docs]: |
There was a problem hiding this comment.
The product-docs link reference is currently empty, resulting in broken links throughout the README. This is likely because the product_documentation field in .repo-metadata.json is empty. Once .repo-metadata.json is updated, this file should be regenerated to include the correct URL.
References
- Avoid manually editing auto-generated files (such as README.md) because changes will be overwritten. Modify the generator or the source metadata instead.
|
Failed |
This change includes google/cloud/sql/v1beta4 and google/cloud/sql/v1.