Skip to content

chore(bigquery-jdbc): refactor PreparedStatement and CallableStatement#13849

Open
Neenu1995 wants to merge 57 commits into
mainfrom
ps-part4-refactor
Open

chore(bigquery-jdbc): refactor PreparedStatement and CallableStatement#13849
Neenu1995 wants to merge 57 commits into
mainfrom
ps-part4-refactor

Conversation

@Neenu1995

@Neenu1995 Neenu1995 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor
  • Centralized Parameter Access & wasNull(): Routed all parameter getter paths in BigQueryCallableStatement through centralized getRawParameter helpers, ensuring consistent wasNull() state tracking across all fast-path and fallback reads.
  • Enforced Lifecycle Validation: Added checkClosed() checks to all implemented methods in BigQueryCallableStatement and BigQueryPreparedStatement.
  • Standardized Logging & Naming: Aligned method parameter names with standard JDBC API conventions and added LOG.finer entry logging.
  • Handled Unsupported Features: Updated unsupported getters (getRef, getSQLXML) to directly throw BigQueryJdbcSqlFeatureNotSupportedException.
  • Cleaned Redundant Code: Removed duplicate state-tracking assignments in calendar-aware date/time/timestamp overloads.

Neenu1995 and others added 30 commits July 16, 2026 12:36
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
… and update CallableStatement and ResultSet to delegate to BigQueryTypeCoercionUtility
…rom BigQueryParameterHandler and delegate directly to BigQueryTypeCoercionUtility
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
…rameterHandlerTest to FieldValueTypeBigQueryCoercionUtilityTest
@Neenu1995
Neenu1995 requested review from a team as code owners July 21, 2026 18:00

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors parameter handling in BigQueryCallableStatement and BigQueryPreparedStatement by standardizing parameter names, adding checkClosed() validation, and introducing helper methods like getRawParameter. Feedback on these changes highlights a few inconsistencies: BigQueryCallableStatement.setDate uses convertDateToCalendar instead of convertDateWithCalendar, the overloaded getObject methods are missing checkClosed() checks, and temporal types are handled inconsistently between BigQueryPreparedStatement (bound as strings) and BigQueryCallableStatement (bound as raw temporal objects).

@Neenu1995 Neenu1995 changed the title chore(bigquery-jdbc): refactor PrepareStatement and CallableStatement chore(bigquery-jdbc): refactor PreparedStatement and CallableStatement Jul 21, 2026
Base automatically changed from ps-part3-callable to main July 22, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants