test(showcase): migrate Thread.sleep calls to Awaitility#13728
Open
blakeli0 wants to merge 3 commits into
Open
test(showcase): migrate Thread.sleep calls to Awaitility#13728blakeli0 wants to merge 3 commits into
blakeli0 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces manual Thread.sleep busy-waiting loops with Awaitility across several integration tests to improve reliability and performance, and adds the awaitility dependency to pom.xml. The review feedback suggests optimizing the usage of Awaitility by leveraging its until(Callable, Predicate) overload. This allows directly returning the evaluated results and avoids redundant calls to metricReader.collectAllMetrics() in ITCompositeTracer, ITOtelGoldenMetrics, and ITOtelMetrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate Thread.sleep and loop constructs in java-showcase to Awaitility.