fix(storage): handle map clears without current state#13725
Open
mahitha-ada wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a hasOriginalState flag to the builders of BlobInfo and BucketInfo to track whether they were initialized with an existing instance's state. This flag helps correctly identify when fields like metadata, contexts, or labels are being cleared on a new builder, ensuring they are properly marked as modified during updates. Additionally, several integration tests have been added to verify this behavior. I have no feedback to provide as there are no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12632
Summary
Root cause
Fresh builders start with null map fields. Updating them to an empty or null value produced no nested differences, so the update mask remained empty and the client performed a read instead of clearing the remote field.
Validation
mvn -pl google-cloud-storage -DskipTests fmt:format(Java 21)mvn -pl google-cloud-storage -am -Dtest=ITUpdateMaskTest,BlobInfoTest,BucketInfoTest -Dsurefire.failIfNoSpecifiedTests=false test(82 tests)git diff --check