feat(bigquery-jdbc): implement driver environment builder#13723
Open
Neenu1995 wants to merge 3 commits into
Open
feat(bigquery-jdbc): implement driver environment builder#13723Neenu1995 wants to merge 3 commits into
Neenu1995 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry capabilities to the BigQuery JDBC driver, adding protobuf definitions, build configurations, environment builders, and configuration settings along with their respective unit tests. The review feedback highlights two important improvements in DriverEnvironmentBuilder: making the getOrCreateTelemetryTag method thread-safe to prevent race conditions in concurrent environments, and validating that the telemetry tag path is a regular file of a reasonable size before reading to avoid potential exceptions or memory issues.
deepak929200
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/527947900
This is PR4 of multi-part telemetry client implementation. This PR implements
DriverEnvironmentBuilderand its corresponding unit tests (DriverEnvironmentBuilderTest) as part of the BigQuery JDBC telemetry client infrastructure.It provides a package-private utility for constructing
DriverEnvironmentprotocol buffer payloads by inspecting client runtime properties and managing a persistent installation-scoped UUID.Key Changes
1.8.xand modern11+/17+formats).DriverEnvironment.OsTypeenums (Windows, macOS/Darwin, Linux, Solaris, BSDs, AIX).major.minor).~/.bigquery-jdbc/telemetry-tag.user.home(serverless/container runtimes), read-only file systems,SecurityExceptions, and automatically overwrites corrupted/invalid file contents with a fresh UUID.