fix(oauth2_http): Avoid retrying on 403 Forbidden during GCE metadata ping#13715
Open
macastelaz wants to merge 6 commits into
Open
fix(oauth2_http): Avoid retrying on 403 Forbidden during GCE metadata ping#13715macastelaz wants to merge 6 commits into
macastelaz wants to merge 6 commits into
Conversation
…erification in tests
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates ComputeEngineCredentials to handle 403 Forbidden responses during the Compute Engine metadata server ping check by immediately returning false instead of logging an unexpected exception. It also introduces a new test case to verify this behavior and adds request counting to MockMetadataServerTransport to ensure no retries occur. There are no review comments, and I have no additional feedback to provide.
fe14912 to
b5f6618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't retry GCE Metadata 403 errors which are generally non-retriable errors and only adds startup noise/latency by retrying 3 times.
Fixes #13649