feat(bigquery-jdbc): optimize memory footprint for JSON result set streaming#13660
Open
Neenu1995 wants to merge 9 commits into
Open
feat(bigquery-jdbc): optimize memory footprint for JSON result set streaming#13660Neenu1995 wants to merge 9 commits into
Neenu1995 wants to merge 9 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces BigQueryJsonStreamParser to parse BigQuery REST JSON responses into lightweight Object[] row buffers, reducing JVM heap overhead and GC pause times. It also updates BigQueryFieldValueListWrapper and BigQueryStatement to support and utilize these lightweight row buffers. The review feedback highlights critical infinite loop vulnerabilities in the JSON parsing loops when handling truncated or abruptly ended streams, and suggests using standard Jackson parsing patterns with explicit null token checks. Additionally, the reviewer recommends chaining constructors to reduce code duplication and removing unused stream parsing methods from the production code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/529436374
BigQueryFieldValueListWrapperusing a static, stateless utility pattern to reduce object allocations during JSON result set parsing.ARRAY,STRUCT,RANGE) outside the page-fetching loop inBigQueryStatementto avoid redundant per-row inspection.FieldValuereferences for complex types (RANGE,ARRAY,STRUCT) during row unpacking to prevent improper string coercion.