chore(bigquery-jdbc): fix flaky testSetTimeout test#13549
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request extracts a 300-second delay query string into ITBase to reuse it across multiple integration tests, and removes an unused helper method in ITStatementTest. The feedback recommends declaring this query string as a public static final constant named QUERY_300_SECONDS to follow standard Java naming conventions. Additionally, it is advised to reference this constant statically in the test classes rather than using inheritance (extends ITBase) solely to access the field.
keshavdandeva
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like BQ can cache results of existing query, so timeout is not reliable. This query is guaranteed to run for 300 seconds, so it will ensure job is killed by timeout.