chore(bigquery-jdbc): dockerized proxy environment to run integration tests#13546
Open
logachev wants to merge 2 commits into
Open
chore(bigquery-jdbc): dockerized proxy environment to run integration tests#13546logachev wants to merge 2 commits into
logachev wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a Dockerized proxy environment for integration testing of the Java BigQuery JDBC driver. It adds multi-stage Docker builds, configures a Squid proxy with iptables rules to restrict raw network access (while allowing Maven Central), and updates the Maven configuration to support skipping the shade plugin. Feedback on these changes highlights two issues: first, the docker-proxy-session target in the Makefile references an undefined .docker-run-proxy target, which will cause execution to fail; second, the proxy readiness check in start-proxy.sh attempts to curl google.com, which is blocked by the iptables rules, and should instead use the allowed Maven Central domain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows building regular & environment with proxy via Dockerfile.
Proxy environment restricts all internet traffic except maven.org, so it allows us to run entire IT suite with proxy to ensure it is operational.
I confirmed that #13539 passes majority of IT (failing tests are due to test setup rather than code, there will be separate PR to fix it & run it as a part of nightly workflow).
I also confirmed that if we had these tests enabled sooner, we'd catch #13494