fix(datastore): disable built-in OpenTelemetry SDK when metrics export is disabled#13543
Draft
lqiu96 wants to merge 2 commits into
Draft
fix(datastore): disable built-in OpenTelemetry SDK when metrics export is disabled#13543lqiu96 wants to merge 2 commits into
lqiu96 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates BuiltInDatastoreMetricsProvider to return a no-op OpenTelemetry instance when built-in metrics export is disabled, preventing unnecessary initialization and potential log spam. Feedback was provided on the test assertion in BuiltInDatastoreMetricsProviderTest.java, suggesting to use isSameInstanceAs(OpenTelemetry.noop()) instead of comparing classes, which is more robust and avoids relying on internal implementation details.
…/cloud/datastore/telemetry/BuiltInDatastoreMetricsProviderTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[DRAFT]
Possible fix for #13469