test(bigtable): quote only the schema bundle ID in ExecuteQueryIT#13540
Open
hopha95 wants to merge 1 commit into
Open
test(bigtable): quote only the schema bundle ID in ExecuteQueryIT#13540hopha95 wants to merge 1 commit into
hopha95 wants to merge 1 commit into
Conversation
Modify the allTypes test in ExecuteQueryIT to only quote the schema bundle ID instead of the whole message in the CAST expression. Fixes: b/526667198
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SQL query string in ExecuteQueryIT.java by adjusting the backtick placement around the schemaBundleId and the proto/enum type names in the CAST expressions. Specifically, the backticks now wrap only the schemaBundleId rather than extending to the end of the fully qualified class names. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the allTypes test in ExecuteQueryIT to only quote the schema bundle ID instead of the whole message in the CAST expression.
Fixes: b/526667198