chore: add org.bouncycastle:bcprov-jdk18on to java-shared-dependencies#13531
chore: add org.bouncycastle:bcprov-jdk18on to java-shared-dependencies#13531sagnghos wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the Bouncy Castle dependency (org.bouncycastle:bcprov-jdk18on, version 1.80) to the shared third-party dependencies and upper-bound check POM files. The reviewer feedback recommends sorting the newly added properties and dependencies alphabetically in both POM files to maintain readability and consistency.
| <dependency> | ||
| <groupId>org.bouncycastle</groupId> | ||
| <artifactId>bcprov-jdk18on</artifactId> | ||
| <version>${bouncycastle.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
The dependencies in <dependencyManagement> should be sorted alphabetically by groupId and artifactId to maintain consistency and avoid merge conflicts. Please move the org.bouncycastle dependency block to its correct alphabetical position (e.g., after org.apache.arrow).
| <dependency> | ||
| <groupId>org.bouncycastle</groupId> | ||
| <artifactId>bcprov-jdk18on</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
The dependencies in this POM should be sorted alphabetically by groupId and artifactId. Please move the org.bouncycastle dependency block before org.jspecify.
…ncies/pom.xml Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This adds BouncyCastle to the shared dependency BOM. It is required to implement the OPAQUE PAKE protocol for Spanner Omni authentication (which relies on Argon2id and low-level Elliptic Curve math not available in standard Java/Tink).
Bug: b/526057728