fix(bigquery-jdbc): fix shading exclusions and telemetry credentials#13515
Open
keshavdandeva wants to merge 2 commits into
Open
fix(bigquery-jdbc): fix shading exclusions and telemetry credentials#13515keshavdandeva wants to merge 2 commits into
keshavdandeva wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenTelemetry relocation exclusions in pom.xml to use double asterisks, and promotes the opentelemetry-sdk-logs dependency from test scope to compile scope. Additionally, in BigQueryJdbcOpenTelemetry.java, it replaces a hardcoded string value with a structured enum name BigQueryJdbcOAuthUtility.AuthType.GOOGLE_SERVICE_ACCOUNT.name() when setting the OAuth type property. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/524234554
This PR fixes two issues in the OpenTelemetry implementation within the BigQuery JDBC driver:
AbstractMethodErrorcrashes when client applications inject custom OTel SDK instances.IllegalArgumentExceptionthrown when parsing OAuth authentication types during zero-config credentials initialization.