test(spanner): deflake R/W transaction test with in-memory harness test for omni#13514
Open
rahul2393 wants to merge 1 commit into
Open
test(spanner): deflake R/W transaction test with in-memory harness test for omni#13514rahul2393 wants to merge 1 commit into
rahul2393 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates a test assertion in LocationAwareSharedBackendReplicaHarnessTest.java to verify that the first replica index is not -1, rather than strictly checking if it is 1. The review feedback suggests strengthening this assertion to explicitly verify that the index is either 0 or 1, preventing potential out-of-bounds calculations in subsequent lines.
sakthivelmanii
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.