Skip to content

chore(java-cloud-bom): migrate java-cloud-bom into monorepo#13498

Open
jinseopkim0 wants to merge 8 commits into
mainfrom
migrate-java-cloud-bom
Open

chore(java-cloud-bom): migrate java-cloud-bom into monorepo#13498
jinseopkim0 wants to merge 8 commits into
mainfrom
migrate-java-cloud-bom

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

b/477663818

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the java-cloud-bom module into the monorepo, introducing BOM configurations, validation tests, a dashboard generator, and release-note utilities. The code review identified several critical issues that need to be addressed: a missing comma in a Python list in updateREADMETable.py causing implicit string concatenation, multiple unclosed file streams in ArtifactMavenData.java and DashboardMain.java leading to resource leaks, a potential deadlock in ReleaseNoteGeneration.java when reading process streams, and missing explicit UTF-8 encoding specifications in both Java and Python file operations.

Comment thread java-cloud-bom/libraries-bom-table-generation/updateREADMETable.py Outdated
Comment thread java-cloud-bom/libraries-bom-table-generation/updateREADMETable.py Outdated
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-cloud-bom branch 2 times, most recently from 546fe09 to 6f9b129 Compare June 17, 2026 15:10
@jinseopkim0 jinseopkim0 force-pushed the migrate-java-cloud-bom branch from 6f9b129 to 209f419 Compare June 17, 2026 15:36
@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@jinseopkim0 jinseopkim0 marked this pull request as ready for review June 18, 2026 09:01
@jinseopkim0 jinseopkim0 requested review from a team as code owners June 18, 2026 09:01
@jinseopkim0 jinseopkim0 requested a review from blakeli0 June 18, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant