fix(bigquery-jdbc): ensure largeResults are handled in PreparedStatement#13496
Open
logachev wants to merge 3 commits into
Open
fix(bigquery-jdbc): ensure largeResults are handled in PreparedStatement#13496logachev wants to merge 3 commits into
logachev wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors BigQueryPreparedStatement to delegate query execution methods to its superclass BigQueryStatement, reducing code duplication. It also updates parameter handling and destination dataset configuration to work with builders, and adds corresponding unit tests. The review feedback correctly points out that the overridden execution methods in BigQueryPreparedStatement now result in redundant logging, as logQueryExecutionStart is already called within the superclass implementations. Suggestions were provided to clean up these redundant logging calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/524708480
Fix the issue where PreparedStatement didn't set destinationTable properties for large results.