Skip to content

test(auth): Assert IOException on custom universe domain with delegation #13477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
westarle wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Draft

test(auth): Assert IOException on custom universe domain with delegation #13477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...rary-java/oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,6 +1762,16 @@ void createScopes_existingAccessTokenInvalidated() throws IOException {
assertNull(newAccessToken);
}

@Test
void getRequestMetadata_withUniverseAndDelegation_throws() {
ServiceAccountCredentials credentials =
createDefaultBuilderWithKey(OAuth2Utils.privateKeyFromPkcs8(PRIVATE_KEY_PKCS8))
.setUniverseDomain("example.com")
.setServiceAccountUser("user@example.com")
.build();
assertThrows(IOException.class, () -> credentials.getRequestMetadata(CALL_URI));

@gemini-code-assist gemini-code-assist Bot Jun 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Asserting a generic IOException can lead to false positives if the method throws an IOException for other reasons (such as configuration or key issues). It is safer to assert that the exception message contains specific text indicating that domain-wide delegation is not supported with a custom universe domain.

    IOException exception =
        assertThrows(IOException.class, () -> credentials.getRequestMetadata(CALL_URI));
    assertTrue(exception.getMessage().contains("universe domain"));

}

private void verifyJwtAccess(Map<String, List<String>> metadata, String expectedScopeClaim)
throws IOException {
assertNotNull(metadata);
Expand Down
Loading