Skip to content

test(auth): verify GoogleCredentials.fromStream throws IOException on invalid JSON #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
westarle wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −0
Draft

test(auth): verify GoogleCredentials.fromStream throws IOException on invalid JSON #13473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce2b4fa
test(auth): verify GoogleCredentials.fromStream throws IOException on…
westarle Jun 15, 2026
dc43176
Update google-auth-library-java/oauth2_http/javatests/com/google/auth…
westarle Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...auth-library-java/oauth2_http/javatests/com/google/auth/oauth2/GoogleCredentialsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,18 @@ void fromStream_unknownType_throws() throws IOException {
}
}

@Test
void fromStream_invalidJson_throws() throws IOException {
// Other client libraries (like Python, Go, and Rust) strictly validate JSON syntax and reject
// malformed payload structures immediately. This test ensures Java maintains parity by
// successfully throwing an IOException when ADC JSON parsing fails, preventing silent fallbacks.
MockHttpTransportFactory transportFactory = new MockHttpTransportFactory();
try (InputStream stream = new ByteArrayInputStream("invalid-json{".getBytes(java.nio.charset.StandardCharsets.UTF_8))) {
assertThrows(
IOException.class, () -> GoogleCredentials.fromStream(stream, transportFactory));
}
}

@Test
void fromStream_nullTransport_throws() {
InputStream stream = new ByteArrayInputStream("foo".getBytes());
Expand Down
Loading