Skip to content

fix(auth): handle missing APPDATA on Windows gracefully #13471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
westarle wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −1
Draft

fix(auth): handle missing APPDATA on Windows gracefully #13471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80f34d1
fix(auth): handle missing APPDATA on Windows gracefully
westarle Jun 15, 2026
4330ac3
Update google-auth-library-java/oauth2_http/java/com/google/auth/oaut…
westarle Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion google-auth-library-java/oauth2_http/java/com/google/auth/oauth2/GoogleAuthUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ static final File getWellKnownCredentialsFile(DefaultCredentialsProvider provide
if (envPath != null) {
cloudConfigPath = new File(envPath);
} else if (provider.getOsName().indexOf("windows") >= 0) {
File appDataPath = new File(provider.getEnv("APPDATA"));
String appData = provider.getEnv("APPDATA");
if (appData == null) {
return null;
}
File appDataPath = new File(appData);
cloudConfigPath = new File(appDataPath, provider.CLOUDSDK_CONFIG_DIRECTORY);
Comment thread
westarle marked this conversation as resolved.
} else {
File configPath = new File(provider.getProperty("user.home", ""), ".config");
Expand Down
15 changes: 15 additions & 0 deletions ...ary-java/oauth2_http/javatests/com/google/auth/oauth2/DefaultCredentialsProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,21 @@ void getDefaultCredentials_noCredentials_throws() {
assertEquals(DefaultCredentialsProvider.CLOUDSDK_MISSING_CREDENTIALS, message);
}

@Test
void getDefaultCredentials_windowsMissingAppData_throwsOrFallback() {
// When APPDATA is unset on Windows, the ADC resolution should fail gracefully
// with a structured missing credentials exception, rather than crashing with an NPE.
// This matches the expected behavior seen in Node.js and Python implementations.
MockHttpTransportFactory transportFactory = new MockHttpTransportFactory();
TestDefaultCredentialsProvider testProvider = new TestDefaultCredentialsProvider();
testProvider.setProperty("os.name", "windows");
testProvider.setEnv("APPDATA", null);

IOException e =
assertThrows(IOException.class, () -> testProvider.getDefaultCredentials(transportFactory));
assertEquals(DefaultCredentialsProvider.CLOUDSDK_MISSING_CREDENTIALS, e.getMessage());
}

@Test
void getDefaultCredentials_noCredentialsSandbox_throwsNonSecurity() {
MockHttpTransportFactory transportFactory = new MockHttpTransportFactory();
Expand Down
Loading