chore: update googleapis commitish to b282a4f#13449
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the IngestAdEvents RPC and its associated messages, such as AdEvent and ViewabilityInfo, to the java-datamanager library, complete with client methods, settings, and tests. It also introduces AgentGateway management to the java-networkservices library and updates existing route path patterns from global to wildcard. The review feedback points out several copy-paste errors and inaccuracies in the newly added protobuf comments (e.g., for ad_format_oneof, view_type, and account_type requirements) and suggests corrections to ensure the documentation is accurate.
| // String value for ad type. | ||
| string ad_type_string = 15; | ||
| } | ||
|
|
There was a problem hiding this comment.
The comment for ad_format_oneof appears to be a copy-paste error from ad_type_oneof. It should describe the format of the ad rather than its type.
| // Optional. The format of the ad served. |
| UNSUPPORTED_LINKED_ACCOUNT_FOR_DATA_PARTNER = 38; | ||
|
|
||
| // Events data contains no user identifiers or ad identifiers. | ||
| // For Floodlight Event ingestion this error indicates requests contains no ad |
There was a problem hiding this comment.
There is a grammatical typo in the comment: "requests contains" should be "requests contain" or "the request contains".
| // For Floodlight Event ingestion this error indicates requests contains no ad | |
| // For Floodlight Event ingestion this error indicates the request contains no ad |
|
|
||
| // Details of the viewability of the ad served. | ||
| message ViewabilityInfo { | ||
| // Required. The type of the event. |
There was a problem hiding this comment.
The comment for view_type appears to be a copy-paste error from event_type. It should describe the viewability type rather than the event type.
| // Required. The type of the event. | |
| // Required. The viewability type. |
| google.protobuf.Duration playback_duration = 8 | ||
| [(google.api.field_behavior) = OPTIONAL]; | ||
| } | ||
|
|
There was a problem hiding this comment.
The comment for ViewType appears to be a copy-paste error from EventType. It should describe the viewability type rather than the event type.
| // The viewability type. |
| // Either `account_type` or the deprecated `product` is required. | ||
| // If both are set, the values must match. |
There was a problem hiding this comment.
Since account_type is now strictly REQUIRED, the statement "Either account_type or the deprecated product is required" is no longer accurate. It is better to simplify the comment to reflect that account_type is required and must match product if both are set.
| // Either `account_type` or the deprecated `product` is required. | |
| // If both are set, the values must match. | |
| // If the deprecated `product` is also set, the values must match. |
Updated googleapis commitish in librarian.yaml and generation_config.yaml to googleapis/googleapis@b282a4f
💡 Note: Please merge or close this PR so that the daily update workflow can continue to run successfully the next day. Alternatively, you can manually trigger the workflow once this PR is merged or closed.