refactor(bigquery): Standardize SimpleQuery samples as used across multiple technologies#13446
Open
Kef131 wants to merge 3 commits into
Conversation
…sing_same_table_as_other_languages
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BigQuery sample query and its integration test to query USA names data from Texas instead of the Shakespeare corpus. The feedback suggests updating the console output label from 'count:' to 'total_people:' to accurately reflect the semantic meaning of the retrieved sum.
…ery/SimpleQuery.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/468097867
Updated the BigQuery simple query sample
SimpleQuery.javaand its integration testSimpleQueryIT.javato query thebigquery-public-data.usa_names.usa_1910_2013public dataset instead of the oldbigquery-public-data.samples.shakespearedataset. This standardizes the query across samples in other languages.Reference on other technologies: https://docs.cloud.google.com/bigquery/docs/running-queries#python
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequired (verifiedSimpleQueryITintegration test passes)mvn -P lint checkstyle:checkrequired (0 checkstyle violations found)mvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only (Skipped due to JDK 25 compatibility issues with configured ErrorProne plugin version during compilation)