feat(bigquery-jdbc): parse endpoint overrides and proxy settings from URL authority#13377
feat(bigquery-jdbc): parse endpoint overrides and proxy settings from URL authority#13377keshavdandeva wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces authority parsing in BigQueryJdbcUrlUtility to extract endpoint overrides or proxy host and port configurations directly from the JDBC URL authority section, along with supporting tests. The review feedback correctly points out that the current proxy parsing logic using indexOf(':') will fail for IPv6 addresses. It is recommended to update the parsing logic to handle IPv6 brackets and add corresponding test cases to prevent regressions.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates BigQueryJdbcUrlUtility to parse the authority part of the JDBC URL, allowing the extraction of endpoint overrides or proxy host and port configuration (including IPv6 addresses). It also adds support for merging multiple endpoint overrides and includes comprehensive unit tests to verify these new parsing capabilities. No review comments were provided, so there is no feedback to address.
b/515051004
Added support for extracting endpoint overrides and proxy routing configurations directly from the authority segment (the host part preceding the first semicolon
;) of the JDBC connection URL.http://orhttps://, it is mapped to theEndpointOverridesproperty (BIGQUERY=...).host:port) and mapped to theProxyHostandProxyPortproperties.EndpointOverrides, settings from the authority and parameter segments are merged, with parameter values overwriting duplicate keys.